Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Webhook for Typetalk #5548

Closed
wants to merge 2 commits into from
Closed

Support Webhook for Typetalk #5548

wants to merge 2 commits into from

Conversation

is2ei
Copy link

@is2ei is2ei commented Dec 15, 2018

#5496

Added Webhook support for Typetalk
Could you please review it? 😃

@is2ei is2ei mentioned this pull request Dec 15, 2018
Closed
@is2ei
Copy link
Author

is2ei commented Dec 15, 2018 •
edited
Loading

I checked the test result and I think it is not caused by my changes.

https://drone.gitea.io/go-gitea/gitea/4547/8

+ make clean
go clean -i ./...
rm -rf gitea dist modules/{options,public,templates}/bindata.go \
	integrations*.test \
	integrations/gitea-integration-pgsql/ integrations/gitea-integration-mysql/ integrations/gitea-integration-sqlite/ integrations/gitea-integration-mssql/ \
	integrations/indexers-mysql/ integrations/indexers-pgsql integrations/indexers-sqlite integrations/indexers-mssql \
	integrations/mysql.ini integrations/pgsql.ini integrations/mssql.ini
+ make generate
package github.com/jteeuwen/go-bindata/...: github.com/jteeuwen/go-bindata/...: invalid import path: malformed import path "github.com/jteeuwen/go-bindata/...": double dot
Makefile:95: recipe for target 'generate' failed
make: *** [generate] Error 1

I ran the command in my local env. It didn't cause the error.

horie at MBP in ~/src/code.gitea.io/gitea on support-webhook-typetalk [?]
$ make generate
go generate code.gitea.io/gitea code.gitea.io/gitea/cmd code.gitea.io/gitea/models code.gitea.io/gitea/models/migrations code.gitea.io/gitea/modules/auth code.gitea.io/gitea/modules/auth/ldap code.gitea.io/gitea/modules/auth/oauth2 code.gitea.io/gitea/modules/auth/openid code.gitea.io/gitea/modules/auth/pam code.gitea.io/gitea/modules/avatar code.gitea.io/gitea/modules/base code.gitea.io/gitea/modules/cache code.gitea.io/gitea/modules/context code.gitea.io/gitea/modules/cron code.gitea.io/gitea/modules/generate code.gitea.io/gitea/modules/highlight code.gitea.io/gitea/modules/httplib code.gitea.io/gitea/modules/indexer code.gitea.io/gitea/modules/lfs code.gitea.io/gitea/modules/log code.gitea.io/gitea/modules/mailer code.gitea.io/gitea/modules/markup code.gitea.io/gitea/modules/markup/csv code.gitea.io/gitea/modules/markup/external code.gitea.io/gitea/modules/markup/markdown code.gitea.io/gitea/modules/markup/orgmode code.gitea.io/gitea/modules/metrics code.gitea.io/gitea/modules/minwinsvc code.gitea.io/gitea/modules/notification code.gitea.io/gitea/modules/notification/base code.gitea.io/gitea/modules/notification/ui code.gitea.io/gitea/modules/options code.gitea.io/gitea/modules/pprof code.gitea.io/gitea/modules/private code.gitea.io/gitea/modules/process code.gitea.io/gitea/modules/public code.gitea.io/gitea/modules/recaptcha code.gitea.io/gitea/modules/search code.gitea.io/gitea/modules/setting code.gitea.io/gitea/modules/ssh code.gitea.io/gitea/modules/sync code.gitea.io/gitea/modules/templates code.gitea.io/gitea/modules/test code.gitea.io/gitea/modules/user code.gitea.io/gitea/modules/util code.gitea.io/gitea/modules/validation code.gitea.io/gitea/routers code.gitea.io/gitea/routers/admin code.gitea.io/gitea/routers/api/v1 code.gitea.io/gitea/routers/api/v1/admin code.gitea.io/gitea/routers/api/v1/convert code.gitea.io/gitea/routers/api/v1/misc code.gitea.io/gitea/routers/api/v1/org code.gitea.io/gitea/routers/api/v1/repo code.gitea.io/gitea/routers/api/v1/swagger code.gitea.io/gitea/routers/api/v1/user code.gitea.io/gitea/routers/api/v1/utils code.gitea.io/gitea/routers/dev code.gitea.io/gitea/routers/org code.gitea.io/gitea/routers/private code.gitea.io/gitea/routers/repo code.gitea.io/gitea/routers/routes code.gitea.io/gitea/routers/user code.gitea.io/gitea/routers/user/setting code.gitea.io/gitea/routers/utils
bindata.go
bindata.go
bindata.go

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2018
lunny
lunny requested changes Dec 15, 2018
View reviewed changes
options/locale/locale_de-DE.ini Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Dec 15, 2018

There is a bug on go1.11.3 I think that made the CI failed.

@is2ei
Copy link
Author

is2ei commented Dec 15, 2018

There is a bug on go1.11.3 I think that made the CI failed.

@lunny Ok! We need to wait fot the CI to be fixed, right?

adelowo
adelowo reviewed Dec 15, 2018
View reviewed changes
modules/setting/setting.go Outdated Show resolved Hide resolved
Support Webhook for Typetalk
68cf72d 
Signed-off-by: Issei Horie <[email protected]>
@codecov-io
Copy link

codecov-io commented Dec 19, 2018 •
edited
Loading

Codecov Report

Merging #5548 into master will decrease coverage by 0.23%.
The diff coverage is 1.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5548      +/-   ##
==========================================
- Coverage   37.76%   37.52%   -0.24%     
==========================================
  Files         325      326       +1     
  Lines       47681    47986     +305     
==========================================
+ Hits        18005    18007       +2     
- Misses      27081    27384     +303     
  Partials     2595     2595
Impacted Files Coverage Δ
models/webhook_typetalk.go 0% <0%> (ø)
models/webhook.go 67.5% <0%> (-1.22%) ⬇️
modules/auth/repo_form.go 38.23% <0%> (-0.77%) ⬇️
routers/repo/webhook.go 1.6% <0%> (-0.18%) ⬇️
modules/setting/setting.go 48.8% <100%> (ø) ⬆️
routers/routes/routes.go 85.14% <100%> (+0.08%) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44759fd...5123f86. Read the comment docs.

@is2ei
Copy link
Author

is2ei commented Dec 19, 2018

@lunny @adelowo
The test is passed! If it is ok, could you give me lgtm?

@lunny lunny added this to the 1.8.0 milestone Dec 20, 2018
@lunny
Copy link
Member

lunny commented Dec 20, 2018

@is2ei I will try this and since v1.7 new feature is freezed, this could be merged on v1.8 .

@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 21, 2018
@techknowlogick techknowlogick modified the milestones: 1.8.0, 1.9.0 Feb 19, 2019
@stale
Copy link

stale bot commented Apr 20, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 20, 2019
@lunny
Copy link
Member

lunny commented Apr 20, 2019

Please resolve the conflicted files.

@stale stale bot removed the issue/stale label Apr 20, 2019
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 4, 2019
@stale
Copy link

stale bot commented Aug 3, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 3, 2019
@lafriks
Copy link
Member

lafriks commented Aug 3, 2019

Conflicts need to be resolved

@stale stale bot removed the issue/stale label Aug 3, 2019
@lunny lunny modified the milestones: 1.10.0, 1.11.0 Sep 15, 2019
@6543
Copy link
Member

6543 commented Nov 2, 2019

@is2ei can you resolve conflicts?

PS: some code has moved so take care of :D

@lunny
Copy link
Member

lunny commented Nov 16, 2019

Please resolve the conflicts.

@techknowlogick techknowlogick modified the milestones: 1.11.0, 1.x.x Dec 12, 2019
@6543
Copy link
Member

6543 commented Dec 28, 2019

@is2ei #9422 made some changes ... so It is worth looking at it ... (you have to resolve conflicts anyway)

@6543
Copy link
Member

6543 commented Dec 28, 2019

@is2ei I know this PR is old ... but do you still have passion to get it upstream?

@stale
Copy link

stale bot commented Feb 26, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 26, 2020
@alexanderadam alexanderadam mentioned this pull request Mar 1, 2020
Open
@stale
Copy link

stale bot commented Apr 26, 2020

This pull request has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this Apr 26, 2020
@lafriks lafriks removed this from the 1.x.x milestone May 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo left review comments

@lunny lunny lunny requested changes

Assignees
No one assigned
Labels
issue/stale lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@is2ei @lunny @codecov-io @lafriks @6543 @adelowo @techknowlogick @bkcsoft